[RFC]: Add file_descriptor() function to retrieve the file descriptor of a PHP Stream #10342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
reviewed
Feb 1, 2023
azjezz
reviewed
Feb 1, 2023
| * It is only used here so that the buffered data warning is not displayed. | ||
| */ | ||
| if (php_stream_can_cast(stream, PHP_STREAM_AS_FD | PHP_STREAM_CAST_INTERNAL) == FAILURE) { | ||
| zend_argument_type_error(1, "cannot represent as a file descriptor"); |
There was a problem hiding this comment.
Suggested change
| zend_argument_type_error(1, "cannot represent as a file descriptor"); | |
| zend_argument_type_error(1, "cannot be represented as a file descriptor"); |
|
it think we miss a test case for closed resources, i.e: $fp = fopen('somefile.txt', 'wb+');
fclose($fp);
try {
var_dump(file_descriptor($fp));
} catch ( ... ) {
...
} |
bukka
reviewed
Mar 17, 2023
|
|
||
| php_stream_from_zval(stream, zsrc); | ||
|
|
||
| /* TODO Should support streams that can be cast with PHP_STREAM_AS_FD_FOR_SELECT ? */ |
There was a problem hiding this comment.
In general PHP_STREAM_AS_FD should be supported if PHP_STREAM_AS_FD_FOR_SELECT which should be the case for all core stream wrappers - I just checked and don't see a case where it would be different. So I wouldn't bother with checking PHP_STREAM_AS_FD_FOR_SELECT as well.
bukka
reviewed
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/file-descriptor-function
The purpose of this function is to retrieve the underlying file descriptors for PHP streams when they exist.
It is currently possible to achieve this result by using FFI and stubbing the Zend engine (see: https://github.com/ppelisset/php-fileno).
This can be needed when trying to interact with a USB device, as this is the use case @ppelisset has.
Test should be based of #10173 when it gets merged.